Skip to content

feat(client): get NVMe bdev controller health info#241

Merged
derekbit merged 1 commit into
longhorn:mainfrom
c3y1huang:12016-monitor-node-disk-health
Nov 27, 2025
Merged

feat(client): get NVMe bdev controller health info#241
derekbit merged 1 commit into
longhorn:mainfrom
c3y1huang:12016-monitor-node-disk-health

Conversation

@c3y1huang

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#12016

What this PR does / why we need it:

  • Adds the BdevNvmeGetControllerHealthInfo() to retrieve health info for an NVMe bdev controller via SPDK.
  • It also normalize the returned temperature to handle invalid readings.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Nov 13, 2025
@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (ba5a970) to head (9a2f551).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/spdk/client/basic.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #241   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         38      38           
  Lines       4859    4870   +11     
=====================================
- Misses      4859    4870   +11     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@c3y1huang c3y1huang force-pushed the 12016-monitor-node-disk-health branch 3 times, most recently from e2da8e1 to 74fdf9a Compare November 20, 2025 00:57
longhorn/longhorn-12016

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the 12016-monitor-node-disk-health branch from 74fdf9a to 9a2f551 Compare November 25, 2025 00:36
@c3y1huang c3y1huang marked this pull request as ready for review November 25, 2025 00:36
@c3y1huang c3y1huang requested review from a team, derekbit and shuo-wu November 25, 2025 00:37

@derekbit derekbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 2ab7a5b into longhorn:main Nov 27, 2025
8 checks passed
@c3y1huang c3y1huang deleted the 12016-monitor-node-disk-health branch November 27, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants