fix(raid): correct stripSizeKb for raid concat#247
Closed
davidcheng0922 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: David Cheng <davidcheng0922@gmail.com>
davidcheng0922
force-pushed
the
issue-10260-lvs-across-disk
branch
from
1959443 to
e14a425
Compare
derekbit
reviewed
Dec 18, 2025
Comment on lines
+781
to
+794
| switch raidLevel { | ||
| case spdktypes.BdevRaidLevel0, spdktypes.BdevRaidLevelRaid0, | ||
| spdktypes.BdevRaidLevel5f, spdktypes.BdevRaidLevelRaid5f: | ||
| // RAID0 / RAID5f keep user-given strip size (non-zero requirement stays external) | ||
| // do nothing | ||
| case spdktypes.BdevRaidLevelConcat: | ||
| // For RAID CONCAT (Concatenation), the strip size is logically useless for its primary function, | ||
| // but it is technically required for initialization and framework compliance. | ||
| // | ||
| // it cannot be 0, will return error | ||
| stripSizeKb = 4 | ||
|
|
||
| default: | ||
| // All other RAID levels do not use strip size → forced to 0 |
Member
There was a problem hiding this comment.
Just curious why we don't use 512 bytes or other size?
Contributor
Author
There was a problem hiding this comment.
If my understanding correct, the raid strip size unit is KiB
The strip size not affect the IO mapping. RAID concat IO in sequential without striping. Strip size only for initialize the bdev raid.
I think it doesn't matter what strip size is, since RAID concat does not use strip size for mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#10260
What this PR does / why we need it:
Fix bug for let
raid concatworksSpecial notes for your reviewer:
Additional documentation or context