fix: use explicit blkid checks to correctly detect empty partitions#263
Merged
Conversation
Signed-off-by: bachmanity1 <bachmanity138@gmail.com>
davidcheng0922
approved these changes
Feb 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR refines how Longhorn detects whether a block device is "in use" by making blkid checks explicit for filesystems and partition tables, improving detection of truly empty devices/partitions.
Changes:
- Introduced
hasFilesystemandhasPartitionTablehelpers that callblkidwith-s TYPEand-s PTTYPErespectively and interpret their outputs. - Updated
IsBlockDeviceInUseto rely on these helpers, returning true only if a filesystem or partition table is actually detected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c3y1huang
reviewed
Feb 4, 2026
c3y1huang
approved these changes
Feb 4, 2026
derekbit
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#12599
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context