feat(ipv6): add IPv6 address family detection and nvme-cli IPv6 fixes#276
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves NVMe/TCP IPv6 support across the SPDK client and nvme-cli initiator integration, adding address-family auto-detection and safer parsing/normalization for IPv6 inputs.
Changes:
- Exported
DetectAddressFamily()inpkg/spdk/clientand used it to select IPv4 vs IPv6 when adding NVMe-oF listeners / setting ANA state. - Added
normalizeNvmeAddr()to strip IPv6 brackets before passing addresses tonvme-cli -a, and added unit tests. - Updated
GetIPAndPortFromControllerAddress()parsing to usestrings.SplitNand added IPv6-oriented unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/spdk/client/advanced.go | Adds exported address-family detection and uses it for listener creation and ANA state setting. |
| pkg/spdk/client/advanced_test.go | Adds unit tests for DetectAddressFamily(). |
| pkg/initiator/nvmecli.go | Normalizes bracketed IPv6 for nvme-cli usage and improves controller address parsing. |
| pkg/initiator/nvmecli_test.go | Adds unit tests for IPv6 normalization and controller address parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
COLDTURNIP
added a commit
to COLDTURNIP/longhorn-go-spdk-helper
that referenced
this pull request
Apr 22, 2026
- Export DetectAddressFamily() in pkg/spdk/client for adrfam auto-detection - Replace hardcoded NvmeAddressFamilyIPv4 in StartExposeBdev/StartExposeBdevWithANAState - Add normalizeNvmeAddr() in pkg/initiator to strip brackets from IPv6 for nvme-cli -a - Use SplitN in GetIPAndPortFromControllerAddress to correctly split IPv6 traddr values Address review comments (PR longhorn#276): - DetectAddressFamily: strip brackets before net.ParseIP so [fd00::1] is handled correctly - normalizeNvmeAddr: downgrade log from Warn to Debug (bracketed IPv6 is normal input) - GetIPAndPortFromControllerAddress: add IPv6 example to function comment Signed-off-by: Raphanus Lo <yunchang.lo@suse.com>
COLDTURNIP
force-pushed
the
10928-v2-engine-ipv6
branch
from
d167ac4 to
ad3285f
Compare
COLDTURNIP
added a commit
to COLDTURNIP/longhorn-go-spdk-helper
that referenced
this pull request
Apr 22, 2026
- Export DetectAddressFamily() in pkg/spdk/client for adrfam auto-detection - Replace hardcoded NvmeAddressFamilyIPv4 in StartExposeBdev/StartExposeBdevWithANAState - Add NormalizeNvmeAddr() in pkg/util to strip brackets from IPv6 addresses - Use NormalizeNvmeAddr in DetectAddressFamily and nvme-cli call sites - Use SplitN in GetIPAndPortFromControllerAddress to correctly split IPv6 traddr values Address review comments (PR longhorn#276): - DetectAddressFamily: delegate bracket stripping to util.NormalizeNvmeAddr - normalizeNvmeAddr: extracted to pkg/util as NormalizeNvmeAddr (shared across packages) - normalizeNvmeAddr: downgrade log from Warn to Debug; removed now it is in util - GetIPAndPortFromControllerAddress: add IPv6 example to function comment Signed-off-by: Raphanus Lo <yunchang.lo@suse.com>
COLDTURNIP
force-pushed
the
10928-v2-engine-ipv6
branch
3 times, most recently
from
e9c921e to
e426ec6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
COLDTURNIP
force-pushed
the
10928-v2-engine-ipv6
branch
from
e426ec6 to
ecdf1c3
Compare
derekbit
reviewed
Apr 22, 2026
Member
derekbit
left a comment
derekbit
left a comment
There was a problem hiding this comment.
In general, LGTM. The comments are more for coding style.
Member
|
After resolving comments, we can merge the PR. |
Signed-off-by: Raphanus Lo <yunchang.lo@suse.com>
COLDTURNIP
force-pushed
the
10928-v2-engine-ipv6
branch
from
ecdf1c3 to
cf51c16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
DetectAddressFamily()in pkg/spdk/client for adrfam auto-detectionNvmeAddressFamilyIPv4inNvmfSubsystemAddListenerandStartExposeBdevWithANAStatewith dynamic detection viaDetectAddressFamily()normalizeNvmeAddr()to strip brackets fornvme-cli -aflagstrings.Split->strings.SplitNinGetIPAndPortFromControllerAddressto handle IPv6 addresses containing colonsIssue longhorn/longhorn#10928
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context