fix(initiator): detect and replace stale endpoint device nodes#281
Merged
Conversation
Previously, createEndpoint() unconditionally reused any existing endpoint without validating it. A stale regular file or a device node with wrong major:minor could be left behind when a previous cleanup races with external writers or when deferred dm removal leaves an orphaned node, causing I/O to be routed to the wrong device. Validate the existing endpoint by stat-ing the node and comparing its type (S_IFBLK) and major:minor against the current dm device. If the endpoint is stale, remove it and recreate with the correct device numbers. Extract the validation into isEndpointValid() for readability. Also set i.isUp = true when reusing a valid endpoint, so that GetEndpoint() returns the correct path instead of an empty string. Longhorn 13062 Signed-off-by: Derek Su <derek.su@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#13062
What this PR does / why we need it:
Previously, createEndpoint() unconditionally reused any existing endpoint without validating it. A stale regular file or a device node with wrong major:minor could be left behind when a previous cleanup races with external writers or when deferred dm removal leaves an orphaned node, causing I/O to be routed to the wrong device.
Validate the existing endpoint by stat-ing the node and comparing its type (S_IFBLK) and major:minor against the current dm device. If the endpoint is stale, remove it and recreate with the correct device numbers. Extract the validation into isEndpointValid() for readability.
Also set i.isUp = true when reusing a valid endpoint, so that GetEndpoint() returns the correct path instead of an empty string.
Special notes for your reviewer:
Additional documentation or context