Skip to content

feat(proxy): implement V2 VolumeExpand #8022#1036

Merged
derekbit merged 2 commits into
longhorn:masterfrom
davidcheng0922:issue-8022-volume-expansion
Sep 11, 2025
Merged

feat(proxy): implement V2 VolumeExpand #8022#1036
derekbit merged 2 commits into
longhorn:masterfrom
davidcheng0922:issue-8022-volume-expansion

Conversation

@davidcheng0922
Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#8022

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Corresponding PR :
longhorn/types#57
longhorn/longhorn-spdk-engine#386
longhorn/go-spdk-helper#224

@davidcheng0922 davidcheng0922 changed the title feat (proxy) : implement V2 VolumeExpand feat (proxy) : implement V2 VolumeExpand #8022 Jul 31, 2025
@davidcheng0922 davidcheng0922 force-pushed the issue-8022-volume-expansion branch from a0dc211 to 801d498 Compare July 31, 2025 03:46
@davidcheng0922 davidcheng0922 changed the title feat (proxy) : implement V2 VolumeExpand #8022 feat (proxy): implement V2 VolumeExpand #8022 Jul 31, 2025
@davidcheng0922 davidcheng0922 changed the title feat (proxy): implement V2 VolumeExpand #8022 feat(proxy): implement V2 VolumeExpand #8022 Jul 31, 2025
@davidcheng0922 davidcheng0922 requested a review from a team July 31, 2025 04:55
@davidcheng0922 davidcheng0922 force-pushed the issue-8022-volume-expansion branch 3 times, most recently from 53d471f to 65296fd Compare August 1, 2025 09:46
@davidcheng0922 davidcheng0922 force-pushed the issue-8022-volume-expansion branch from 746a0c4 to 15ae3f5 Compare August 13, 2025 03:51
@derekbit derekbit force-pushed the issue-8022-volume-expansion branch from 15ae3f5 to 4776996 Compare August 31, 2025 08:37
Copy link
Copy Markdown
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the PR in longhorn-spdk-engine

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 31, 2025

This pull request is now in conflict. Could you fix it @davidcheng0922? 🙏

derekbit
derekbit previously approved these changes Sep 7, 2025
Copy link
Copy Markdown
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for longhorn-spdk-engine.

Signed-off-by: David Cheng <davidcheng0922@gmail.com>
@derekbit
Copy link
Copy Markdown
Member

CI failed.
It seems go.mod is not updated?

@derekbit
Copy link
Copy Markdown
Member

@mergify backport v1.10.x

@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 11, 2025

backport v1.10.x

✅ Backports have been created

Details

@davidcheng0922 davidcheng0922 force-pushed the issue-8022-volume-expansion branch from a5010d8 to c16c016 Compare September 11, 2025 02:35
Signed-off-by: David Cheng <davidcheng0922@gmail.com>
Copy link
Copy Markdown
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 99e3e82 into longhorn:master Sep 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants