feat: support snapshot max count for v2 (backport #1391)#1394
Merged
Conversation
Longhorn: 12921 Signed-off-by: David Cheng <david.cheng@suse.com> (cherry picked from commit 1ecf693) # Conflicts: # go.mod # go.sum # vendor/modules.txt
Author
|
Cherry-pick of 1ecf693 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Member
|
Hello @davidcheng0922 Could you update the go.mod to use v1.12.x longhorn-spdk-engine? Thank you. |
Contributor
Done, thank you |
derekbit
reviewed
May 15, 2026
| github.com/longhorn/longhorn-engine v1.12.0-rc1.0.20260514055507-33e0c9c94743 | ||
| github.com/longhorn/longhorn-spdk-engine v1.12.0-rc2.0.20260514112050-c9306c85100e | ||
| github.com/longhorn/types v0.0.0-20260513135851-499d5d1f4e79 | ||
| github.com/longhorn/longhorn-spdk-engine v0.0.0-20260515051212-7e0ddb934b91 |
Member
There was a problem hiding this comment.
https://github.com/longhorn/longhorn-spdk-engine/commits/v1.12.x/
The commit id should be a07df50fb05a43d68790e95954fd08cf3f8bdd2b
6fca282 to
800d45a
Compare
Longhorn: 12921 Signed-off-by: David Cheng <david.cheng@suse.com>
800d45a to
840e76e
Compare
derekbit
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#12921
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
This is an automatic backport of pull request #1391 done by [Mergify](https://mergify.com).