Skip to content

fix: Allow deleting orphans while retaining the data#3924

Open
nzhan126 wants to merge 1 commit intolonghorn:masterfrom
nzhan126:issue11286
Open

fix: Allow deleting orphans while retaining the data#3924
nzhan126 wants to merge 1 commit intolonghorn:masterfrom
nzhan126:issue11286

Conversation

@nzhan126
Copy link
Contributor

@nzhan126 nzhan126 commented Jul 14, 2025 •
edited by derekbit
Loading

check for DeleteCustomResourceOnly label in orphan when deciding whether to clean the data associated

longhorn/longhorn#11286

Which issue(s) this PR fixes:

Issue #11286

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nzhan126 nzhan126 force-pushed the issue11286 branch 2 times, most recently from b1707d1 to 4b3eeca Compare July 14, 2025 21:31
@nzhan126 nzhan126 marked this pull request as ready for review July 14, 2025 21:32
@nzhan126 nzhan126 requested a review from shuo-wu July 14, 2025 21:55
shuo-wu
shuo-wu reviewed Jul 17, 2025
View reviewed changes
@shuo-wu shuo-wu mentioned this pull request Jul 17, 2025
Open
@nzhan126 nzhan126 marked this pull request as draft July 18, 2025 23:21
@nzhan126 nzhan126 marked this pull request as ready for review July 24, 2025 17:23
shuo-wu
shuo-wu reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Longhorn still try to delete the orphan automatically after a replica reuses its data directory?

@nzhan126
Copy link
Contributor Author

nzhan126 commented Jul 25, 2025

Will Longhorn still try to delete the orphan automatically after a replica reuses its data directory?

@shuo-wu Yes the orphan will be deleted automatically, data stay.

shuo-wu
shuo-wu reviewed Sep 5, 2025
View reviewed changes
@innobead innobead requested a review from COLDTURNIP September 7, 2025 15:48
COLDTURNIP
COLDTURNIP approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@COLDTURNIP COLDTURNIP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzhan126 @derekbit
fix: allow deleting orphans while retaining the data
83fe24e 
check for DeleteCustomResourceOnly label in orphan
if label is set to true, skip data cleaning

ref#11286

Signed-off-by: Nina Zhan <112509390+nzhan126@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuo-wu shuo-wu shuo-wu left review comments

@COLDTURNIP COLDTURNIP COLDTURNIP approved these changes

Assignees

@nzhan126 nzhan126

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nzhan126 @COLDTURNIP @shuo-wu