fix(workflow): remove pull_request_target from conventional-commits.yml#722
Merged
Conversation
Longhorn 12754 Signed-off-by: Derek Su <derek.su@suse.com>
There was a problem hiding this comment.
Pull request overview
Updates the Conventional Commits GitHub Actions workflow to avoid using the pull_request_target trigger (per longhorn/longhorn#12754), reducing the workflow’s exposure to elevated permissions when running on PRs.
Changes:
- Switch workflow trigger from
pull_request_targettopull_request. - Add explicit
contents: readpermission. - Checkout PR HEAD commit explicitly before running commit/PR lint checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mantissahz
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#12754
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context