revert: feat(engine): add I/O suspension during replica deletion#403
Merged
Conversation
This reverts commit f640e45. ref: longhorn#376 Longhorn 11109 Signed-off-by: jinhong.kim0 <hookak25@gmail.com>
hookak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f640e45. Longhorn 11109
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#11109
What this PR does / why we need it:
This PR reverts commit
f640e455c81df7c2d7b008263beae9528ace1a2f.(#376), which suspended I/O during replica deletion.Although that change did not cause functional failures, it can negatively affect client I/O while a replica is being deleted. SPDK already performs an internal quiesce(suspension of I/O) during base bdev removal, so keeping the additional suspend increases client-visible impact.
Special notes for your reviewer:
Additional documentation or context