fix(backup): harden backup failure handling#533
Merged
Conversation
Member
Author
|
@mergify backport v1.12.x |
✅ Backports have been createdDetails
|
Check replica state before reading snapshot data so backups fail through the normal error path when the replica is no longer running. Also make UpdateBackupStatus preserve error as the final state even when progress reaches 100, and add tests to cover both error-first and error-after-completion cases. Longhorn 12842 Signed-off-by: Derek Su <derek.su@suse.com>
davidcheng0922
approved these changes
May 18, 2026
davidcheng0922
approved these changes
May 18, 2026
mantissahz
approved these changes
May 18, 2026
Contributor
mantissahz
left a comment
mantissahz
left a comment
There was a problem hiding this comment.
LGTM
And derekbit/longhorn-instance-manager:issue-12842-03 works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#12842
What this PR does / why we need it:
Check replica state before reading snapshot data so backups fail through the normal error path when the replica is no longer running.
Also make UpdateBackupStatus preserve error as the final state even when progress reaches 100, and add tests to cover both error-first and error-after-completion cases.
Special notes for your reviewer:
Additional documentation or context