fix(recovery): do not tear down host initiator/dm resources on recovery failure#544
Closed
derekbit wants to merge 1 commit into
Closed
fix(recovery): do not tear down host initiator/dm resources on recovery failure#544derekbit wants to merge 1 commit into
derekbit wants to merge 1 commit into
Conversation
…ry failure Previously, recoverEngineFrontends called ef.Delete() when recovery failed or the frontend was superseded by a concurrent Create. Delete() invokes initiator.Stop() which disconnects NVMe controllers and removes device-mapper devices — potentially destroying resources that still serve active I/O for the new frontend (same subsystem NQN). Longhorn 13185 Signed-off-by: Derek Su <derek.su@suse.com>
Member
Author
|
@mergify backport v1.12.x |
🟠 Waiting for conditions to matchDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#13185
What this PR does / why we need it:
Previously, recoverEngineFrontends called ef.Delete() when recovery failed or the frontend was superseded by a concurrent Create. Delete() invokes initiator.Stop() which disconnects NVMe controllers and removes device-mapper devices — potentially destroying resources that still serve active I/O for the new frontend (same subsystem NQN).
Special notes for your reviewer:
Additional documentation or context