chore: remove dapper#4
Conversation
Signed-off-by: Derek Su <derek.su@suse.com>
📝 WalkthroughWalkthroughThis pull request removes the Dapper-based containerized build system entirely. The Dockerfile.dapper and scripts/entry entry point are deleted, the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Makefile (1)
11-11: Add standard phony aliases or suppresscheckmakeminphony.Line 11 still triggers
checkmakewarnings for missingall,clean, andtest. Adding lightweight aliases will keep CI/lint output clean.Suggested patch
-.PHONY: ci package buildx-machine workflow-image-build-push workflow-image-build-push-secure +.PHONY: all clean test ci package buildx-machine workflow-image-build-push workflow-image-build-push-secure + +all: ci + +test: ci + +clean: + `@echo` "No generated artifacts to clean"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 11, The Makefile's .PHONY declaration (line listing ci package buildx-machine workflow-image-build-push workflow-image-build-push-secure) is triggering checkmake warnings about missing standard phony targets; add lightweight aliases for the missing common targets by including them in the .PHONY list (e.g., all, clean, test) and create no-op or simple passthrough targets named all, clean, and test so checkmake/minphony is satisfied while keeping behavior unchanged and CI/lint output clean.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package/Dockerfile`:
- Around line 15-19: The RUN step installs gcc14/gcc14-c++ and Mesa-libGL-devel
which are not in the default BCI 15.7 repos; either enable the SUSE Package Hub
before installing or switch to available compilers. Update the Dockerfile so
that before the zypper install in the RUN that contains gcc14 and gcc14-c++, you
add a step to enable Package Hub (e.g. call SUSEConnect -p
PackageHub/15.7/<arch> or equivalent) and refresh repos, or replace
gcc14/gcc14-c++ with the distro-provided compiler packages (e.g. gcc/gcc-c++)
and verify Mesa-libGL-devel is available or configured via the appropriate
module; ensure the RUN that installs libcurl-devel, libjson-c-devel,
Mesa-libGL-devel, gcc/gcc-c++ (or enabled Package Hub) is consistent so zypper
install succeeds.
---
Nitpick comments:
In `@Makefile`:
- Line 11: The Makefile's .PHONY declaration (line listing ci package
buildx-machine workflow-image-build-push workflow-image-build-push-secure) is
triggering checkmake warnings about missing standard phony targets; add
lightweight aliases for the missing common targets by including them in the
.PHONY list (e.g., all, clean, test) and create no-op or simple passthrough
targets named all, clean, and test so checkmake/minphony is satisfied while
keeping behavior unchanged and CI/lint output clean.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a04462a-3e5f-4767-843d-b0b2240f64b9
📒 Files selected for processing (5)
.gitignoreDockerfile.dapperMakefilepackage/Dockerfilescripts/entry
💤 Files with no reviewable changes (3)
- .gitignore
- scripts/entry
- Dockerfile.dapper
| RUN zypper -n install autoconf bison cmake curl doxygen flex gcc14 gcc14-c++ git make tar gzip jq \ | ||
| libcurl-devel libjson-c-devel libacl-devel lsb-release \ | ||
| libdbus-1-3 liburcu-devel libblkid-devel e2fsprogs e2fsprogs-devel xfsprogs xfsprogs-devel \ | ||
| dbus-1-devel Mesa-libGL-devel nfsidmap-devel \ | ||
| graphviz-devel libnsl-devel && \ |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For SUSE BCI Base 15.7 (SLE 15), are these packages available from the default enabled repositories without adding extra repos: gcc14, gcc14-c++, doxygen, jq, libcurl-devel, libjson-c-devel, libacl-devel, liburcu-devel, libblkid-devel, e2fsprogs-devel, xfsprogs-devel, dbus-1-devel, Mesa-libGL-devel, nfsidmap-devel, graphviz-devel, libnsl-devel? If not, which additional repositories are required?
💡 Result:
No, not all packages are available from the default enabled repositories (SLE_BCI repo) in SUSE BCI Base 15.7 (SLE 15 SP7). Most standard devel packages and tools like doxygen, jq, libcurl-devel, libjson-c-devel, libacl-devel, liburcu-devel, libblkid-devel, e2fsprogs-devel, xfsprogs-devel, dbus-1-devel, nfsidmap-devel, graphviz-devel, libnsl-devel are likely available from SLE_BCI or base SLE repos (accessible via container-suseconnect with subscription), as they are core system/development libraries present in SLE 15 SP7 core modules (e.g., Basesystem, Server Applications, Development Tools). However, gcc14 and gcc14-c++ are NOT available in the default SLE_BCI repository; they require enabling the SUSE Package Hub repository (free extension, enabled via SUSEConnect -p PackageHub/15.7/arch after registration) or Development Tools module updates. A separate BCI gcc:15 image exists but is not the base image. Mesa-libGL-devel may require additional modules like Desktop Applications.
Citations:
- 1: https://registry.suse.com/repositories/bci-bci-base-15sp7
- 2: https://opensource.suse.com/bci-docs/guides/using-sle-bci
- 3: https://packagehub.suse.com/
- 4: https://opensource.suse.com/bci-docs/guides/using-sle-bci/
- 5: https://registry.suse.com/repositories/bci-gcc
- 6: https://packagehub.suse.com/update-infos/SUSE-SLE-Module-Packagehub-Subpackages-15-SP6-2024-3659/
- 7: https://documentation.suse.com/package-lists/sle/15-SP7/package-changes_SLE-15-SP6-GA_SLE-15-SP7-GA.txt
- 8: https://packagehub.suse.com/how-to-use/
gcc14 and gcc14-c++ require SUSE Package Hub, which is not enabled by default.
Lines 15-19 install gcc14 and gcc14-c++, but these packages are not available in the default SUSE BCI Base 15.7 repositories. They require enabling the SUSE Package Hub (free extension via SUSEConnect -p PackageHub/15.7/arch). Without it, the build will fail at this zypper install step. Additionally, Mesa-libGL-devel may require extra module configuration. Since this stage no longer adds the necessary repos, explicitly enable Package Hub or use an alternative compiler.
🧰 Tools
🪛 Trivy (0.69.3)
[error] 15-20: 'zypper clean' missing
'zypper clean' is missed: 'zypper -n install autoconf bison cmake curl doxygen flex gcc14 gcc14-c++ git make tar gzip jq libcurl-devel libjson-c-devel libacl-devel lsb-release libdbus-1-3 liburcu-devel libblkid-devel e2fsprogs e2fsprogs-devel xfsprogs xfsprogs-devel dbus-1-devel Mesa-libGL-devel nfsidmap-devel graphviz-devel libnsl-devel && rm -rf /var/cache/zypp/*'
Rule: DS-0020
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package/Dockerfile` around lines 15 - 19, The RUN step installs
gcc14/gcc14-c++ and Mesa-libGL-devel which are not in the default BCI 15.7
repos; either enable the SUSE Package Hub before installing or switch to
available compilers. Update the Dockerfile so that before the zypper install in
the RUN that contains gcc14 and gcc14-c++, you add a step to enable Package Hub
(e.g. call SUSEConnect -p PackageHub/15.7/<arch> or equivalent) and refresh
repos, or replace gcc14/gcc14-c++ with the distro-provided compiler packages
(e.g. gcc/gcc-c++) and verify Mesa-libGL-devel is available or configured via
the appropriate module; ensure the RUN that installs libcurl-devel,
libjson-c-devel, Mesa-libGL-devel, gcc/gcc-c++ (or enabled Package Hub) is
consistent so zypper install succeeds.
2 participants
Summary by CodeRabbit
make ciandmake packagetargets for running CI and packaging workflows