Removed Iron Router dependency

[satyavh]

Replaced Iron Router dependency with meteorhacks:picker, which means you can now use this package with Flow Router as well:

Uses meteorhacks:picker for server side routing
emailForUrl helper supports both Iron Router and Flow Router
Updated readme

Bumped to v0.7.0 - I thought it was quite major ;-)

[satyavh]

I was thinking, before you accept this PR, people might be using Iron Router. So if they do any IR related stuff in the routes, that won't work anymore and break their code.

So maybe we should do a check for IR, and if there's IR we use that to setup server-side routes. Then the update will be backwards compatible.

[johanbrook]

So maybe we should do a check for IR, and if there's IR we use that to setup server-side routes. Then the update will be backwards compatible.

True. The change will cause unexpected things in people's actions, surely. I'd suggest we add Iron Router as a weak dependency (this package loads after Iron Router), and use a configuration flag:

Mailer.config({
  useIronRouter: true  // defaults to false
});

If set to true, we'll use Iron Router to create the email routes within this package, else Picker.

We'll advertise this in the README. Imo it's okay to introduce some breaking changes in 0.x versions.

Thanks again! 🎉

[johanbrook]

Did you mean to store this in baseUrl here?

I also think we should have a fallback mechanism if the user has neither FlowRouter nor Iron Router installed. Like, doing a logger warning in the console.

[satyavh]

ai, that line should be.

 # if Flow Router
if FlowRouter?
   Utils.joinUrl Mailer.settings.baseUrl, FlowRouter.path.call(FlowRouter, routeName, params.hash)

I'll change that. Sure, we can add a fallback mechanism

[satyavh]

Or we can just check for

if Router?
  # do Iron Router stuff
else
  # do Picker stuff

that way we don't need to introduce any other dependencies and no config.

[johanbrook]

Sounds good!