This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Working around meteor packaging issue, and adding underscore as NPM d… #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabcode
force-pushed
the
fix/underscore-dependancy
branch
from
3a3f131 to
190a832
Compare
|
Cool, does this run for you okay in the embedded sample app? I'll give it a run tomorrow as well. It looks like the package builds okay for people when it's embedded in a Meteor app, but fails when building from Atmosphere. |
|
I haven't tried the embedded app, but did in my app, and it worked just fine. |
|
Alright! I'll give it a run. |
…ependancy, not atmosphere one
grabcode
force-pushed
the
fix/underscore-dependancy
branch
from
190a832 to
9f5cfd2
Compare
|
I've fixed the lint issue 👍 |
|
Hm, this worked in the example app when I pulled this branch and built it. But after merging, it yielded the same errors as in the issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ependancy, not atmosphere one.