Skip to content

Conversation

ryan-szns
Copy link

Currently, the UI and app only supports connecting to one table per BigQuery Data Agent.

Given the flexibility of the Conversational API's Python SDK, it would be a low effort, high reward feature to append more BigQueryTableReferences to the table_references list.

@ryan-szns ryan-szns requested review from a team as code owners October 8, 2025 14:29
Copy link

google-cla bot commented Oct 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

Summary of Changes

Hello @ryan-szns, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability for a BigQuery Data Agent to reference multiple tables from the same dataset. The UI has been updated to accept a comma-separated list of table IDs, and the backend logic now processes these into individual BigQueryTableReference objects, enhancing the flexibility of data agent configurations.

Highlights

  • Intent: This pull request aims to enhance the BigQuery Data Agent functionality by allowing it to connect to multiple tables from the same BigQuery dataset. Previously, the UI and application only supported a single table reference per agent. This change leverages the underlying Conversational API's Python SDK to append multiple BigQueryTableReference objects, providing greater flexibility.
  • Changes Overview: The core change involves modifying the BigQuery data source configuration in the UI to accept multiple table IDs and updating the backend logic to process these IDs into a list of BigQueryTableReference objects. This transitions from a single table input field to a multi-line text area for comma-separated table IDs.
  • File Changes: The changes are confined to app_pages/agents.py.
  • app_pages/agents.py: The bq_table_id st.text_input field has been replaced with a bq_table_ids st.text_area to allow users to input multiple BigQuery table IDs, separated by commas. The associated logic has been updated to parse this comma-separated string, iterate through each table ID, and create a list of BigQueryTableReference objects. Each object is populated with the common project_id and dataset_id, but with its unique table_id, before being assigned to datasource_references.bq.table_references.
  • Reviewer Activity: No specific reviewer activity has been noted in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Overall, this is a great enhancement that adds valuable flexibility for BigQuery data sources. The changes are well-contained and the logic is sound. I have one suggestion to improve the code's readability and adhere to Python best practices.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant