Skip to content

Conversation

JorickvdHoeven
Copy link

Problem Statement

Henry has been having two large issues making it difficult to use:

  1. The Pulse command is failing because of an issue in the Looker SDK with the try_connection command.
  2. The queries were running against the i__looker explore which seems to be getting deprecated or seems to be inaccessible to users who aren't admins.

These two problems impact Henry's ability to run and make it difficult to use. We need to fix these so that people can continue to use Henry to administer their Looker instances.

Proposed solution

  1. Pulse command not working:

    • Given that the reason why the pulse command isn't working is because of the deprecation of the i__looker explore and the fact that the sdk try_connection is broken, we need to catch the exception generated by the sdk and update the queries to use the system_activity explore instead of the i__looker explore.
  2. Analyze queries not working:

    • i__looker is an explore that is either deprecated or limited to admins, given that generally not all users are admins we should update to use the system_activity explore and update the fields that are used so that we can leverage this explore. An added benefit is that the system_activity explore (on a sample of 1 instance) runs much faster than i__looker.

Jorick van der Hoeven added 3 commits October 19, 2022 09:19
This adds typing hings to the cli.py file to allow us to
leverage mypy analysis of the file and identify any type
errors.
The pulse command was using outdated 3.0 API calls to
Looker and the try_connection sdk command is broken in the
Looker 4.0 sdk so we need to catch the exception.

This also updates the queries to run with the latest Looker
back end model and using the system_activity explores instead
of the i__looker explore.
@google-cla
Copy link

google-cla bot commented Oct 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant