Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: fix linter issues #38

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

SuperManifolds
Copy link
Contributor

Description

Changes the Polyglot errors to follow Go code style conventions for error names.
This change may break any external code that checks for specific Polyglot errors by name in their error handling

Fixes Issue FRPC-11

Type of change

  • Refactor (non-breaking change which does not add functionality) [title: 'refactor:']
  • Breaking change (fix, feature, or refactor that would change existing functionality or interfaces) [title: 'BREAKING CHANGE:']

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

These breaking changes will need to be updated throughout scale right?

@SuperManifolds SuperManifolds merged commit 3453256 into staging Apr 2, 2024
9 of 10 checks passed
@SuperManifolds SuperManifolds deleted the alex/frpc-11-fix-linter-issues branch April 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants