Skip to content

fix: --subscribed=false should unsubscribe users#28

Merged
notnmeyer merged 1 commit into
mainfrom
fix/contacts-subscribed-flag
Mar 24, 2026
Merged

fix: --subscribed=false should unsubscribe users#28
notnmeyer merged 1 commit into
mainfrom
fix/contacts-subscribed-flag

Conversation

@notnmeyer

Copy link
Copy Markdown
Member

i noticed the --subscribed flag wasn't unsubbing. the flag actually needs to be a string so we can parse the intent. previously, omitting the flag was false and including it was true, which was not exactly what we wanted. this works as expected now.

➜ task -- contacts find -e nate+1@loops.so -ojson | jq -r ".[].subscribed"
true

➜ task -- contacts update -e nate+1@loops.so -s false
Updated.

➜ task -- contacts find -e nate+1@loops.so -ojson | jq -r ".[].subscribed"
false

@notnmeyer notnmeyer self-assigned this Mar 24, 2026
@notnmeyer notnmeyer requested a review from nalanj March 24, 2026 14:11
@notnmeyer notnmeyer enabled auto-merge (squash) March 24, 2026 14:11
@notnmeyer notnmeyer merged commit 05f93c4 into main Mar 24, 2026
2 checks passed
@notnmeyer notnmeyer deleted the fix/contacts-subscribed-flag branch March 24, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant