[fix] gtsam for rolling and kilted#718
Merged
wentasah merged 2 commits intolopsided98:developfrom Oct 20, 2025
Merged
Conversation
Collaborator
|
Thanks. Can you add a comment that boost is an optional dependency, but enabled by default? And add a link to borglab/gtsam#2171. And add it just for kilted and rolling, not for everything in distro-overlay. From the PR it seems that boost may not be needed in the future and if we have it in distro-overlay, it would probably stay there forever. |
Contributor
Author
|
@wentasah Thanks for your input. I moved the overrides. |
Collaborator
|
Thanks. I just squashed the two changes and separated whitespace cleanup to a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.