Skip to content

Add a bounding box class to store dimensions and anchor. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martindemello wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add a bounding box class to store dimensions and anchor. #185

martindemello wants to merge 5 commits into from

Conversation

@martindemello
Copy link
Contributor

@martindemello martindemello commented May 7, 2019

Reworks a bunch of property update code in Actor to use a bounding box.

This is a refactoring en route to supporting more transformations (flipping, scaling).

@martindemello
Add a bounding box class to store dimensions and anchor.
13e1397 
Rework a bunch of property update code in Actor to use a bounding box.
@martindemello
Add scale and flip transforms.
81df5ba
@martindemello
Copy link
Contributor Author

martindemello commented May 8, 2019

Fixes #3, addresses #36 via a slightly different API

@martindemello martindemello mentioned this pull request May 8, 2019
Open
@lordmauve
Copy link
Owner

lordmauve commented Aug 16, 2019

I'm so sorry, I must have missed this PR! (GitHub emails were going into my spam folder for a time). I will pull it and review when I get a chance.

@martindemello
Copy link
Contributor Author

martindemello commented Aug 16, 2019

no worries, i figured life just got busy for you :)

@martindemello
Copy link
Contributor Author

martindemello commented May 13, 2020

ping? i still feel like this would make doing several other things easier (e.g. #193 and #213)

@martindemello
Copy link
Contributor Author

martindemello commented Aug 23, 2021

One last try at getting this merged - it would let me send in fixes for several other issues (#193, #131, #36 and #3) pretty quickly, and I'd be happy to rework it to fix any issues you have with the code, or if it conflicts with some other ideas you have for pgzero.

@lordmauve lordmauve added enhancement New feature or request actor Issues/PRs involving Actor objects xform Transformations for Actors and removed enhancement New feature or request labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

actor Issues/PRs involving Actor objects xform Transformations for Actors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martindemello @lordmauve