update: concatenate Arrays when target node is an array #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggestion to be able to update an array by concatenating the given `update` array to any target array. This is done only if target AND update are of `array` types. An example overlay is provided as a unit test.
|
Thanks for proposing this change. I think it's sensible and useful functionality, but it's covering something that isn't particularly clear in the overlays spec itself what the right behaviour is. We should probably try to clarify the intended behaviour before we merge a change to this library. |
|
Another similar conversation over here: OAI/Overlay-Specification#30 It would be good to really flesh out whats meant to happen with an array when its "updated", is it replaced, concatenated, merged (with overrides happening somehow), etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to be able to update an array by concatenating
the given
updatearray to any target array.This is done only if target AND update are of
arraytypes.An example overlay is provided as a unit test.