[codex] use crates.io trusted publishing#1004
Merged
Merged
Conversation
Contributor
WASM Size Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CARGO_REGISTRY_TOKENsecret to crates.io Trusted Publishing.releaseenvironment required for trusted publisher matching.contents: writebecause the publish job still pushes cargo-release tags after publishing.Why
The current workflow fails at crates.io with
403 Forbidden: authentication failedbecause the storedCARGO_REGISTRY_TOKENis invalid or no longer has the required publish permissions.loro-ffialready usesrust-lang/crates-io-auth-action@v1successfully, so this alignslorowith that approach and removes the need for a long-lived crates.io token in GitHub Secrets.Validation
.github/workflows/publish-crates.ymlwith Ruby YAML.publish-crates.ymlchanged.Follow-up
Before the next Rust release, configure Trusted Publishing on crates.io for each crate this workflow publishes:
loro-dev/loro.github/workflows/publish-crates.ymlrelease