[codex] deprecate get-or-create container guidance#1008
Draft
zxch3n wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the legacy get-or-create child-container APIs for lazy map-key child creation and updates public guidance to prefer mergeable containers.
Changes
get_or_create_container/getOrCreateContaineras deprecated while preserving existing behavior.insert_container/setContainercreate regular op-id child containers, and thatensure_mergeable_*/ensureMergeable*should be used for lazy map-key child creation that must converge across peers.Validation
cargo check -p loro-internalcargo check -p lorocargo check -p loro-wasmcargo test -p loro --test mergeable_public_apicargo test -p loro --test contractscargo test -p loro --test loro_rust_test test_get_or_create_container_with_nullpnpm -C crates/loro-wasm exec tsc --noEmitpnpm -C crates/loro-wasm exec vitest run tests/mergeable.test.tspnpm checkNotes
The website source is not in this worktree, so external
loro.devtutorial updates are not included here.