feat!: protocol v1 - #34
Merged
Merged
Conversation
zxch3n
marked this pull request as ready for review
December 5, 2025 10:11
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the protocol to v1
DocUpdateso peers can correlate acknowledgments.Ack(0x08) to positively confirm or reject updates; v0 relied onUpdateErrormessages and had no explicit success signal.UpdateErrortoRoomError, which evicts the peer from the room until it rejoins.okis now0x00,unknownmoves to0x01, and the remaining codes keep their numeric values from v0.RoomErrormeans the peer will stop receiving room traffic unless it performs a new join handshake.Why these changes (v1)
Ackfor each update batch (or fragment batch) lets applications know whether a change was accepted instead of inferring success from silence.RoomErrordistinguishes "your update failed" from "you are no longer in the room", enabling clients to stop syncing and prompt rejoin or escalation.okto0x00andunknownto0x01aligns status bytes with common success/failure conventions and leaves room for app-specific errors.