ci: split ShellCheck into its own path-gated job - #106
Merged
Conversation
ShellCheck lived inside the frontend job, so the change detector lumped scripts/ and module/ into the frontend bucket — a scripts-only or module-only PR ran the full bun install + biome + vite build + vitest just to lint a shell script. Move ShellCheck to its own job gated on a new `shell` change output (module/ + scripts/), and narrow the frontend filter to the actual frontend inputs (frontend/, package.json, bun.lock, biome.json). A shell-only change now runs seconds of shellcheck instead of the whole frontend pipeline; the ci aggregator gains the new job in its needs.
loss-and-quick
force-pushed
the
ci/split-shellcheck-job
branch
from
June 22, 2026 17:03
b36f4a4 to
f3a4a74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the ShellCheck step out of the
frontendCI job into its own path-gated job, so a scripts-only or module-only PR no longer runs the entire frontend pipeline just to lint a shell script.Before: ShellCheck lived inside the
frontendjob, so thechangesdetector lumpedscripts/andmodule/into thefrontendbucket. A PR touching onlyscripts/foo.shran the fullbun install+biome check+vite build+vitest— minutes of work — to reach a shellcheck that takes seconds. (This is exactly what made thefrontendjob run on the core-compat PR, which only added a shell script.)After:
shellcheckjob, gated on a newshellchange output (module/+scripts/).shellcheckships on theubuntu-latestrunner, so the job is just checkout + lint.frontendfilter is narrowed to the actual frontend inputs:frontend/,package.json,bun.lock,biome.json(biome only lintsfrontend/**, confirmed inbiome.json, so droppingscripts//module/is safe).ciaggregator gainsshellcheckin itsneeds, so it stays the single required check (a skippedshellarea is treated as pass, same as the others).Net effect: a shell-only change runs ~seconds of shellcheck; a frontend-only change no longer pays for shellcheck; both still run when both areas change.
Affected layer
frontend/— React Web UIcrates/·src-tauri/— Rust core / backend / Tauri desktopmodule/scripts/.github/Verification
actionlint .github/workflows/ci.ymlcleanshellcheck -s sh module/*.sh,-s bash module/customize.sh scripts/*.sh)ciaggregator'sneedsupdatedChecklist
Notes for reviewers
main, touches onlyci.yml.shellcheckskipped (no shell change) → resultskipped→ treated as pass by the existing loop.