docs(build): document the debug_assertions policy - #130
Open
loss-and-quick wants to merge 1 commit into
Open
Conversation
Pin down what debug_assertions governs (dev-only: frontend codegen + Windows dev console) so nightly/release stay plain assertions-off builds that never depend on it. Record it in AGENTS.md and align the comments at both cfg(debug_assertions) sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin down the debug-vs-release policy so it stops being ambiguous.
debug_assertionsgoverns dev-only behavior and nothing else:export_generated,src-tauri/src/lib.rs),windows_subsystem,src-tauri/src/main.rs).Nightly and release are plain
cargo tauri build(release profile, assertions off) and must not depend ondebug_assertionsfor any shipped behavior; the product version is injected viatauri build --config, not a build profile. Records this inAGENTS.mdand aligns the comments at bothcfg(debug_assertions)sites. No behavior change.Affected layer
crates/·src-tauri/— Rust (comments only)AGENTS.mdVerification
cargo fmt --all --checkcargo check -p kasumi-desktopComment/markdown-only; no logic, types, codegen, or strings changed.
Checklist
Notes for reviewers
Documentation/intent only — establishes the contract so future work doesn't overload
debug_assertions.