fix(ci): don't sign updater artifacts in nightly - #72
Merged
Conversation
`bundle.createUpdaterArtifacts` is true globally, so `tauri build` demanded the minisign key and failed the (intentionally unsigned) nightly with "A public key has been found, but no private key". Override it to false for the nightly build — only release.yml has the signing key, and the updater never points at nightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly desktop build failed at bundling:
bundle.createUpdaterArtifacts: trueis set globally intauri.conf.json, so everytauri build(including the intentionally unsigned nightly) tries to emit a signed.sigand aborts when the minisign key isn't present. Onlyrelease.ymlwiresTAURI_SIGNING_PRIVATE_KEY.Fix: override
bundle.createUpdaterArtifactstofalsefor the nightly build (an extra--config). Nightly artifacts are unsigned test builds the updater never points at, so they don't need a.sig. Release signing is unchanged.Affected layer
.github/Verification
actionlint .github/workflows/nightly.ymlclean--configoverride merges overtauri.bundle.conf.json(later--configwins; deep-merged, so other bundle settings are preserved)Notes for reviewers
The secret was set correctly — the problem was purely that nightly never passed it (by design) yet the global flag forced signing. Disabling the artifact for nightly is cleaner than exposing the signing key to scheduled builds.