ci(release): only auto-release on schedule for upstream core bumps - #93
Merged
Merged
Conversation
The weekly cron previously cut a release whenever any code commit had landed in a build-affecting path, so every active week shipped a patch release on autopilot. Gate the code-commit trigger behind a non-schedule event: on the Monday cron only an upstream core bump (xray / tun2socks / sing-box) auto-releases, while a manual workflow_dispatch still releases on code commits as before. force=true is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The weekly release cron (
0 3 * * 1) cut a release whenever any code commit had landed in a build-affecting path since the last tag — so every week with active development shipped a patch release on autopilot, with no human in the loop.This gates the code-commit trigger behind a non-
scheduleevent:workflow_dispatch) — unchanged: still releases on code commits, with thebump/skip_bump/forceinputs.force=true— unchanged.The change is a single conditional:
has_code_commitsnow only flipsskip=falsewhengithub.event_name != 'schedule'. Core-bump detection (which setsbump=minor) is untouched, so kernel updates still ship automatically every Monday.Affected layer
frontend/— React Web UIcrates/·src-tauri/— Rust core / backend / Tauri desktopmodule/— Android installable zip (thin launcher over the Rust daemon)scripts/— build / release helpers.github/Verification
actionlint(v1.7.12, the version pinned inlint-workflows.yml) clean onrelease.yml— includes the shellcheck pass over the editedrun:block.Checklist
frontend/src/generated/not touchedNotes for reviewers
Behaviour matrix after this change:
workflow_dispatchworkflow_dispatch+forceTo cut a code-only release on demand, run the workflow manually from the Actions tab.