ci(nightly): scope concurrency per branch - #96
Merged
Conversation
The nightly concurrency group was the static "nightly", shared across every branch, so dispatching a nightly on one branch cancelled an in-flight nightly on another (two manual runs 13s apart cancelled each other on "Set up job"). Key the group on github.ref so cancel-in-progress only supersedes an older run of the same branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Nightly workflow's concurrency group was the static
nightly, shared across every branch:With
cancel-in-progress: true, dispatching a nightly on one branch cancelled an in-flight nightly on another branch. Seen in practice: two manualworkflow_dispatchruns 13 seconds apart on different branches (feat/proxy-modeat 11:51:36,feat/asset-auto-updateat 11:51:49) — the second cancelled the first, leaving itsmodule/desktopjobs cancelled on "Set up job".Keying the group on
github.refscopes cancellation to a single branch: a newer run still supersedes an older run of the same branch (the intent ofcancel-in-progress), but parallel branches no longer fight over one global slot. This matches the per-discriminator style already used insync-bun-nix.yml(sync-bun-nix-${{ github.event.pull_request.number }}).release.yml's globalreleasegroup is intentionally left as-is — it's a deliberate single global lock (cancel-in-progress: false) so two releases never bumpmodule.propat once.Affected layer
frontend/— React Web UIcrates/·src-tauri/— Rust core / backend / Tauri desktopmodule/— Android installable zip (thin launcher over the Rust daemon)scripts/— build / release helpers.github/Verification
actionlint(v1.7.12, the version pinned inlint-workflows.yml) clean onnightly.ymlChecklist
frontend/src/generated/not touchedNotes for reviewers
Pure CI scoping fix; no build logic touched.