Merged
Conversation
7 tasks
Member
Author
|
Fixed this faraday-live failure in f8615d5: |
iMacTia
previously approved these changes
Sep 20, 2019
Member
iMacTia
left a comment
There was a problem hiding this comment.
Standardising the different adapters can only benefit us in the future, so big 👍 from me
olleolleolle
previously approved these changes
Oct 15, 2019
Member
olleolleolle
left a comment
There was a problem hiding this comment.
I have proof-read all this, and it looks clear.
The new supporting methods help a lot!
Update for latest #request_timeout changes.
…lue. This is so that it returns an HTTP response object from the client lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
#build_connectionand#connectionto the adapters, as suggested in #1006 (comment).