Skip to content

Cleanup adapter connections #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 17, 2019
Merged

Cleanup adapter connections #1023

merged 13 commits into from
Oct 17, 2019

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Sep 20, 2019 •
edited
Loading

This adds #build_connection and #connection to the adapters, as suggested in #1006 (comment).

  • TODO
    • excon
    • httpclient
    • net_http_persistent
    • net_http
    • patron
  • SKIP
    • EM HTTP - Is external pooling needed with the EM reactor?
    • EM Synchrony - EM reactor
    • rack - No actual HTTP connection
    • test - No actual HTTP connection
    • typhoeus - Maintained externally. Can file patch later!

@technoweenie technoweenie marked this pull request as ready for review September 20, 2019 11:36
@technoweenie technoweenie mentioned this pull request Sep 20, 2019
Open
7 tasks
@technoweenie
Copy link
Member Author

technoweenie commented Sep 20, 2019 •
edited
Loading

Fixed this faraday-live failure in f8615d5:

$ FARADAY_GEM_REF=ba7b82d9a2211c4fdd840189e246dbd7a6e4c229 docker-compose build tests
$ docker-compose run tests

  1) net_http_persistent with unverified HTTPS server succeeds with verification disabled
     Failure/Error: res = conn.get('unverified_with_verification')

     Faraday::SSLError:
       SSL_connect returned=1 errno=0 state=error: certificate verify failed (unable to get local issuer certificate)

iMacTia
iMacTia previously approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardising the different adapters can only benefit us in the future, so big 👍 from me

olleolleolle
olleolleolle previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have proof-read all this, and it looks clear.

The new supporting methods help a lot!

@technoweenie technoweenie merged commit 520e357 into master Oct 17, 2019
@technoweenie technoweenie deleted the cleanup-adapter-connections branch October 17, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@iMacTia iMacTia iMacTia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technoweenie @olleolleolle @iMacTia