Skip to content

Set middleware_mutex when middleware/adapter classes are defined #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Mar 27, 2020

Description

See #1074.

This PR is a rebase on master in order to be able to run the tests in GitHub Actions. (At the time of #1074 being authored, CI was in a period of change.)

Todos

  • Tests

Additional Notes

Optional section

@olleolleolle
Copy link
Member Author

@ioquatix 👋 We had this lying around.

@olleolleolle
Copy link
Member Author

OK, I know that this caused no special conflicts. Will rebase the other branch which had all the good metadata, instead.

@olleolleolle olleolleolle deleted the middleware-mutex-preload-1065 branch March 27, 2020 20:56
@ioquatix
Copy link
Contributor

Just FYI, klass.middleware_mutex should probably hit a dedicated method... you could even define Module.initialize or something similar (not sure if that name would conflict).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants