Only load what is required from cgi#1623
Merged
iMacTia merged 2 commits intolostisland:mainfrom May 12, 2025
Merged
Conversation
In Ruby 3.5 most of the `cgi` gem will be removed. Only the various escape/unescape methods will be retained by default. On older versions, `require "cgi/util"` is needed because the unescape* methods don't work otherwise. https://bugs.ruby-lang.org/issues/21258
olleolleolle
approved these changes
May 11, 2025
iMacTia
approved these changes
May 12, 2025
Member
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
This is passing on all 3.0+ Ruby versions, including 3.5.0.dev, thank you 🙇 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Ruby 3.5 most of the
cgigem will be removed. Only the various escape/unescape methods will be retained by default.On older versions,
require "cgi/util"is needed because the unescape* methods don't work otherwise.Additional Notes
https://bugs.ruby-lang.org/issues/21258