Skip to content

fix: sync Composite values with Lottie schema - #21

Merged
Aidosmf merged 1 commit into
mainfrom
mf/sync-composite-values
Jul 24, 2026
Merged

fix: sync Composite values with Lottie schema#21
Aidosmf merged 1 commit into
mainfrom
mf/sync-composite-values

Conversation

@Aidosmf

@Aidosmf Aidosmf commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • correct Composite stacking values to Below = 1 and Above = 2
  • keep the modern namespace constants and deprecated Composite.VALUE aliases in sync
  • add exact runtime and literal-type regression coverage
  • add a patch changeset

Context

The formal lottie-spec 1.0.1 schema does not yet define repeaters or Composite. This focused correction follows the exhaustive Lottie Docs schema and its corrected mapping: https://github.com/LottieFiles/lottie-docs/blob/main/schema/constants/composite.json

Validation

  • yarn test
  • yarn changeset status --since=origin/main
  • git diff --check origin/main...HEAD

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 13ad1e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottie-animation-community/lottie-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Aidosmf Aidosmf self-assigned this Jul 23, 2026
@Aidosmf
Aidosmf marked this pull request as ready for review July 23, 2026 18:00
@Aidosmf
Aidosmf requested a review from kudanai July 23, 2026 18:00

@kudanai kudanai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against lottie-docs schema/constants/composite.json (1=Below, 2=Above) — matches. The deprecated Composite.VALUE enum references the constants so it auto-syncs, the repeater m?: Composite.Value field is unaffected, and both runtime (assert-constants.cjs) and literal-type (types.ts) coverage are updated. This is the exact follow-up flagged on #19. LGTM 🚀

@Aidosmf
Aidosmf merged commit c683f9d into main Jul 24, 2026
3 checks passed
@Aidosmf
Aidosmf deleted the mf/sync-composite-values branch July 24, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants