-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Allow a 'default locale' and locale switcher on status pages #3523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wampiedriessen
wants to merge
11
commits into
louislam:master
Choose a base branch
from
wampiedriessen:feature/locale_on_status_page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
457a3e7
Allow a 'default locale' and locale switcher on status pages
wampiedriessen a483ea6
Fix linter issues
wampiedriessen 995b115
Update src/mixins/lang.js
wampiedriessen 24968f3
Update src/mixins/lang.js
wampiedriessen 7226686
Update src/mixins/lang.js
wampiedriessen c3b4ad8
Convert migration to knex migration
wampiedriessen b755800
Fix linter warning
wampiedriessen 836199d
Fix that localeSelector hides/shows on config change
wampiedriessen 1557f58
Appease vue linter
wampiedriessen 41a6b1f
Merge branch 'master' into feature/locale_on_status_page
wampiedriessen 67fd260
Merge branch 'master' into feature/locale_on_status_page
CommanderStorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
db/knex_migrations/2023-09-13-1047-locale-on-statuspage.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
exports.up = function (knex) { | ||
return knex.schema | ||
.alterTable("status_page", function (table) { | ||
table.boolean("show_locale_selector").notNullable().defaultTo(false); | ||
table.string("default_locale").nullable().defaultTo(""); | ||
}); | ||
}; | ||
|
||
exports.down = function (knex) { | ||
return knex.schema | ||
.alterTable("status_page", function (table) { | ||
table.dropColumn("default_locale"); | ||
table.dropColumn("show_locale_selector"); | ||
}); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being nullable and defaulting to a blang string is kind of strange db-design.
I think you meant either