-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat: add support for 12-hour time format #3838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @CommanderStorm , thanks for the feedback! Resolved all the tasks, can you please take another look and get this merged? Reg. the comment on creating a radio button component, I'd be happy to take that up as a separate PR after this. |
@CommanderStorm Seeing your approval, I have pulled the PR out of draft. Please merge this, TIA! |
Looping in @louislam in case only they have write access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good feature to have. However, having to fetch the setting from database every time the monitor details page loads is too inefficient. We should just fetch the setting once on initial load, and cache it in $root
. The Settings page handling can stay the same.
…a/uptime-kuma into feature/time-format
@chakflying Thanks for the feedback! Made changes mentioned on the files.
How would this behave when a user goes to settings and change the time format and then come back to dashboard? Wouldn't the old format persist, since the data is fetched only during initial load and cached? Isn't the existing call a necessary expense? |
We can update the stored value after the user saves the Setting. Since it is stored in |
@louislam Can we please get this merged? TIA! |
The |
@chakflying What lifecycle event/.. would you recomend instead? |
This would be great to get this merged in! |
Would love to see this get revived! 24-hour time is cumbersome to read for people in regions where it is not used, so this feature would be appreciated :) |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #2654
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots
Set to 12-in Settings -> General
12
-hours24
-hours