Skip to content

Conversation

louislam
Copy link
Owner

@louislam louislam commented Dec 4, 2023

Similar to #4123.

The impact won't be so big for synced fs operations, as the blocking time is very short. But blocking is blocking, it is good to be non-blocking.

And I always thought the async one must be callback-type, which I always don't like it, that's why I always write them in the sync version. And I just realized that they added promise support since Node.js 11.

const fs = require("fs/promises");

@louislam louislam added this to the 2.1.0 milestone Dec 12, 2023
@CommanderStorm CommanderStorm added A:monitor Issues or PRs related to monitors A:core Issues or PRs describing changes to the core of uptime kuma labels Apr 3, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 23, 2024
@github-actions github-actions bot removed the pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:core Issues or PRs describing changes to the core of uptime kuma A:monitor Issues or PRs related to monitors needs:resolve-merge-conflict pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants