Skip to content

Conversation

PurTahan
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this seems really good (no issues that I can spot, there is some autoformatting done by an IDE/.. but nothing bad).

Could you include a screenshot of a message being send to Bale (so we are sure that you have tested it and don't need to spend time setting up this notification provider)?

@CommanderStorm CommanderStorm added A:notifications Issues or PRs related to notifications type:new proposing to add a new monitor pr:please address review comments this PR needs a bit more work to be mergable labels Nov 27, 2024
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Nov 27, 2024
@PurTahan
Copy link
Contributor Author

Screenshot_20241128_030908_Bale.png

Here is default testing messeage and custum messeages.

@CommanderStorm CommanderStorm added pr:depends on other pending other things to be done first and removed pr:please address review comments this PR needs a bit more work to be mergable labels Nov 28, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.1 merge window and will only be merged once that opens

@louislam louislam changed the base branch from master to 2.1.X December 31, 2024 14:59
@louislam louislam merged commit e9935d7 into louislam:2.1.X Dec 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:notifications Issues or PRs related to notifications pr:depends on other pending other things to be done first type:new proposing to add a new monitor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants