-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add Webpush notification provider #5444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable.
I have not had time to work if it works, but here are a few code comments to unblock you.
@CommanderStorm just pushed latest changes with fixes for comments. thank you for the feedback! |
This comment was marked as spam.
This comment was marked as spam.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CommanderStorm I ran NPM INSTALL and pushed the updated "package-lock.json" file. Apologies for the delay. Please let me know if anything else is needed. |
@DoidoYo there seems to be a merge conflict preventing merging. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Add Web push notification provider for progressive web apps, works with most modern browsers on desktop, iOS and theoretically android (tested on windows 10 edge, chrome. macOS safari, chrome. iOS safari.)
Type of change
Please delete any options that are not relevant.
Checklist
NOTES
Screenshots (if any)