Skip to content

Conversation

DoidoYo
Copy link

@DoidoYo DoidoYo commented Dec 16, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Add Web push notification provider for progressive web apps, works with most modern browsers on desktop, iOS and theoretically android (tested on windows 10 edge, chrome. macOS safari, chrome. iOS safari.)

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

NOTES

  1. HTTPS is needed for this to work. Specifically for non localhost urls (tested on Mac safari and chrome). For iOS: HTTPS + page added to Home Screen.
  2. serviceWorker is needed for web push, had to install Vite PWA in order to attach a service worker to the application. ** OF NOTE ** Service worker is only attached in production, NOT attached in dev. will not work in dev
  3. "Webpush Documentation" can be an Uptime Kuma wiki page with more detailed info on point 1 above. I can write it up after code approval.

Screenshots (if any)

image IMG_1748

@DoidoYo DoidoYo marked this pull request as draft December 16, 2024 19:39
@DoidoYo DoidoYo marked this pull request as ready for review December 16, 2024 20:18
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable.

I have not had time to work if it works, but here are a few code comments to unblock you.

@DoidoYo
Copy link
Author

DoidoYo commented Dec 31, 2024

@CommanderStorm just pushed latest changes with fixes for comments. thank you for the feedback!

@ShadowGaming100

This comment was marked as spam.

@penso

This comment has been minimized.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification provider looks good from my point of view.
I just merged master, but thought that I had edit rights to your repo - I have not, since you opened the PR from master.

image

Please run npm install for merging.

@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 17, 2025
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone May 18, 2025
@louislam louislam linked an issue Jun 6, 2025 that may be closed by this pull request
@DoidoYo
Copy link
Author

DoidoYo commented Sep 3, 2025

@CommanderStorm I ran NPM INSTALL and pushed the updated "package-lock.json" file. Apologies for the delay. Please let me know if anything else is needed.

@CommanderStorm
Copy link
Collaborator

@DoidoYo there seems to be a merge conflict preventing merging.
Due to the above mentioned issue, I need you to resolve the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:resolve-merge-conflict pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again

Projects

None yet

4 participants