feat: add an tls option to the tcp-port monitor

[rouja]

Tick the checkbox if you understand [x]:

• I have read and understand the pull request rules.

Description

Add a montior to check tls certificate on TCP connexion with others protocols thant HTTP.

Type of change

• New feature (non-breaking change which adds functionality)

Checklist

• My code follows the style guidelines of this project
• I ran ESLint and other linters for modified files
• I have performed a self-review of my own code and tested it
• I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
• My changes generates no new warnings
• My code needed automated testing. I have added them (this is optional task)

Screenshots

Monitor Configuration

Monitor Résults when it's ok

Change settings of certificate notification

Résult when monitor failed

[CommanderStorm]

Lets go back a step:
how is this different from TCP Port?
Why can this not be integrated/merged with said monitor?

[rouja]

You are absolutely right. We can probably integrate things with this monitor. I think I was afraid of breaking something.

[rouja]

Hello

I rebased on master and pushed a new proposal. I kept the old commit, but once the proposal is approved, I will squash them. The behavior is slightly different because the probe will not go down when the certificate is about to expire. It will simply send a notification, as with other probes.

[CommanderStorm]

once the proposal is approved, I will squash them

no need to squash (please don't). Makes reviewing a bit harder as I need to do this from scratch every time if you do.

The behavior is slightly different because the probe will not go down when the certificate is about to expire. It will simply send a notification, as with other probes.

If it is indeed expired or non responsive, it should go down. That would be a bug.

[rouja]

Hello,

I just pushed a new version addressing all your remarks. I hope it’s all good now.

[rouja]

Hello,

Could I please have an update regarding this PR?

Thank you.

[CommanderStorm]

the update to this PR is that it needs looking at. It is on the to-review list.

Reviewer capacity from my side is severly limited this semester - I am taking 38 ECTS and have a working student job.
Might a while till I get to this. Feel free to help in reviewing, if you'd like ^^

[chakflying]

Tested working okay, only comment is that we can be more clear by reporting the TLS error in the message.

[rouja]

Hello,

Could I please have an update regarding this PR?

Thank you.

[louislam]

I am late to this pr. Tested the feature is working fine, just the behaviour of Certificate Expiry Notification is not consistent with HTTPS/HTTP Monitor.

HTTPS/HTTP Monitor's Certificate Expiry Notification:

• Checked = Check TLS with expiry notifications
• Unchecked = Still check TLS , but no expiry notifications

This pr's Certificate Expiry Notification:

• Checked = Check TLS with expiry notifications
• Unchecked = No TLS checking

Since in http montior, we have the protocol http/https to determine. Maybe we need to add another checkbox to determine whether it is using TLS?

Remark for testing: https://badssl.com/ with port 443.