Skip to content

Conversation

cyril59310
Copy link
Contributor

⚠️ Please Note: We do not accept all types of pull requests, and we want to ensure we don’t waste your time. Before submitting, make sure you have read our pull request guidelines: Pull Request Rules

❗ Important Announcement

Click here for more details:

🚧 Temporary Delay in Feature Requests and Pull Request Reviews

At this time, we may be slower to respond to new feature requests and review pull requests. Existing requests and PRs will remain in the backlog but may not be prioritized immediately.

  • Reason: Our current focus is on addressing bugs, improving system performance, and implementing essential updates. This will help stabilize the project and ensure smoother management.
  • Impact: While no new feature requests or pull requests are being outright rejected, there may be significant delays in reviews. We encourage the community to help by reviewing PRs or assisting other users in the meantime.
  • What You Can Do: If you're interested in contributing, reviewing open PRs by following our Review Guidelines or offering support to other users is greatly appreciated. All feature requests and PRs will be revisited once the suspension period is lifted.

We appreciate your patience and understanding as we continue to improve Uptime Kuma.

🚫 Please Avoid Unnecessary Pinging of Maintainers

We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are reserved for critical/urgent pull requests that require immediate attention.

Why: Reserving pings for urgent matters ensures maintainers can prioritize critical tasks effectively.

📋 Overview

Provide a clear summary of the purpose and scope of this pull request:

  • What problem does this pull request address?

    • The solution is to check whether an avatar image is defined in the Discord webhook payload.

      If no avatar is defined by the user, we will set the default Uptime Kuma image as the avatar.

      If the user has defined a custom avatar in the webhook settings, we will respect their choice and keep their custom image.

🔄 Changes

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

🔗 Related Issues

📄 Checklist *

  • 🔍 My code adheres to the style guidelines of this project.
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

Avatar not set
image
image

avatar set
image
image

ℹ️ Additional Context

Provide any relevant details to assist reviewers in understanding the changes.

Click here for more details:

Key Considerations:

  • Design decisions – Key choices or trade-offs made during development.
  • Alternative solutions – Approaches considered but not implemented, along with reasons.
  • Relevant links – Specifications, discussions, or resources that provide context.
  • Dependencies – Related pull requests or issues that must be resolved before merging.
  • Additional context – Any other details that may help reviewers understand the changes.

Provide details here

💬 Requested Feedback

  • Mention documents needing feedback here

@cyril59310 cyril59310 mentioned this pull request Jun 7, 2025
18 tasks
@CommanderStorm CommanderStorm changed the title Add default avatar in notification discord (Proposed Solution for #5883) Add default avatar in discord notifications Jun 7, 2025
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@CommanderStorm CommanderStorm merged commit c46772d into louislam:master Jun 7, 2025
29 of 30 checks passed
@cyril59310 cyril59310 deleted the Add-avatar-notification-discord branch June 7, 2025 19:43
@CommanderStorm CommanderStorm added this to the 2.0.0-beta.4 milestone Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants