Docker-Monitor: better handling of state "unhealthy" #6292
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Overview
Problem: Docker-Containers in state "unhealthy" are currently marked as "PENDING". Therefore no notification will be send.
With this change the monitor throws an error, if container is unhealthy - in PENDING-State there will be no notification. Setting container DOWN in this state is also wrong. Throwing an error results in notifiing after configured number or retries. Best solution so far for me, works well here in my setup.
PENDING, notDOWN#4369PENDING, notDOWN#4369There was already a PR adressing this problem (#4372), but this solution is not a good one. There are also "running" containers marked as down.
🛠️ Type of change
📄 Checklist