-
-
Notifications
You must be signed in to change notification settings - Fork 7k
feat: make mariadb max pool connections controllable via env #6386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make sure that all environment variables stick to our existing naming scheme
https://github.com/louislam/uptime-kuma/wiki/Environment-Variables#mariadb-environment-variables
I am also not entirely sure if the min pool size should be configurable. What is the effect there?
It's now following standards and i removed the min connections env |
|
I think it needs some validations. Like checking a empty string, |
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks 🙏
Should be uncontroversial and help the few people on a limited pool Mariadb hoster
Head branch was pushed to by a user without write access
|
@CommanderStorm i added validation as Louis said |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please polish your code one round.
Please instead default to 10 and then add an if statement if the env var contains a valid number.
Number.MAX_SAFE_INTEGER for example is not a sensible max.
Also please log if a value does not get applied.
|
Plus, you don't need to call |
|
Changes:
|
📋 Overview
I saw an issue saying that mariadb max connections should be controllable through env variables so this PR fixes that with a new env variable:
🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes