Skip to content

Conversation

@amirparsadd
Copy link
Contributor

📋 Overview

Currently, unknown notifications are sent without any kind of formatting (like creating an embed, fixing link formatting) and this PR aims to fix that by these things:

  • put unknown notifications in embeds
  • convert cert expiry link formatting to markdown formatting on embed body

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

@louislam
Copy link
Owner

I think it is the 3rd time.

Warning

IT IS NOT A MARKDOWN MESSAGE. IT IS JUST A PLAIN TEXT.

Don't let me say again please. It won't be merged.

You hack the message here using regex, just make a trap here for future us.

If you really need markdown, write your own discord bot to receive notification, and parse it in your discord bot.

I won't say again.

#6388 (comment)

@amirparsadd
Copy link
Contributor Author

@louislam i did not update the implementation of cert notifications

I updated how the discord notification provider handles them

@amirparsadd
Copy link
Contributor Author

Atleast we can keep in the unknown notification embed

What can i do other than regex to make this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants