feat: add icons to monitors - #7761
Open
WoutNerd wants to merge 5 commits into
Open
Conversation
Contributor
|
Thanks for the PR! If anyone would like to help with testing, run: |
WoutNerd
marked this pull request as draft
August 24, 2026 13:36
WoutNerd
marked this pull request as ready for review
August 24, 2026 13:57
This was referenced Aug 24, 2026
Contributor
Author
|
I can implement this with a general switch case statement. The implementation of this pr is in my opinion easier to read than a switch case although the switch case approach would be shorter in # of lines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, the following changes are made:
add type icons to monitors (Monitor Type Indicator Icons #7512)
add favicon to http(s) monitors (Show favicon of service #443)
Resolves Show favicon of service #443 and Monitor Type Indicator Icons #7512
added @fortawesome/free-brands-svg-icons as a dependency for the docker and nodejs icons
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit. I used gemini to give me some recommendations to which icon i should use.
Screenshots for Visual Changes