Skip to content

feat: add icons to monitors - #7761

Open
WoutNerd wants to merge 5 commits into
louislam:masterfrom
WoutNerd:icons-for-monitors
Open

feat: add icons to monitors#7761
WoutNerd wants to merge 5 commits into
louislam:masterfrom
WoutNerd:icons-for-monitors

Conversation

@WoutNerd

Copy link
Copy Markdown
Contributor

Summary

In this pull request, the following changes are made:

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out. There are none
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit. I used gemini to give me some recommendations to which icon i should use.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate. Simple UI change, no extra/altered test needed
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before:
    • Before dashboard
    • Before statuspage
  • After:
    • After dashboard
    • After statuspage

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR! If anyone would like to help with testing, run: npx kuma-pr WoutNerd:icons-for-monitors (requires Node.js and Docker)

@WoutNerd WoutNerd changed the title add icons to monitors feat: add icons to monitors Aug 24, 2026
@WoutNerd
WoutNerd marked this pull request as draft August 24, 2026 13:36
@WoutNerd
WoutNerd marked this pull request as ready for review August 24, 2026 13:57
@github-actions github-actions Bot added the pr:needs review this PR needs a review by maintainers or other community members label Aug 24, 2026
@WoutNerd

WoutNerd commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

I can implement this with a general switch case statement. The implementation of this pr is in my opinion easier to read than a switch case although the switch case approach would be shorter in # of lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show favicon of service

1 participant