Fix /nick spam with our away presence: send /nick only if nick changed #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch: lab.louiz.org is down; use catchorg/Catch2, pin latest v1
- slixmpp: broke python 3.7 in v1.8 (cf below): pin 1.7 branch
slixmpp error:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/slixmpp/types.py", line 16, in <module>
from typing import (
ImportError: cannot import name 'Literal' from 'typing' (/usr/lib/python3.7/typing.py)
python2 is not packaged anymore in alpine.
88fe178 lost the "nick has actually changed" check before sending /nick to IRC. This reintroduces is it. This issue became apparent with biboumi connecting to ZNC, and with multiple xmpp clients for the same JID, resulting in a lot of presence stanza forwarded by biboumi as a lot of /nick. Result: libera.chat didn't like it and responded regularly with: > lead.libera.chat: MyNick: ZNC is already trying to get this nickname
Niluge-KiWi
force-pushed
the
fix-nick-spam
branch
from
86e90b8 to
99cbe2e
Compare
|
Active repo here: https://codeberg.org/poezio/biboumi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(stack PR on top of #9)
88fe178 lost the "nick has actually changed" check before sending /nick to IRC.
This reintroduces is it.
This issue became apparent with biboumi connecting to ZNC, and with multiple xmpp clients for the same JID, resulting in a lot of presence stanza, forwarded by biboumi as a lot of /nick.
Result: libera.chat didn't like it and responded regularly with: