Implement LCD demo #110
Merged
Implement LCD demo #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
I was wanting to merge this but the display driver is causing the offset issue we were also seeing on SonataXL because the LCDs we installed on the ArtyA7 are different from the ones currently on Sonata. I don't know if we have the receive line connected up in the ArtyA7 setup, so not sure if the detection code will work form the v0.3.0 of the display drivers.
Update code from upstream repository https://github.com/engdoreis/display_drivers.git to revision d0ea11852c43bd7db2ba9316e4170b8297a1d6a0 * Fix text rendering when font is not monospace (Gary Guo) * Add m3x6 font (Gary Guo) * Add font bitmap generation tool (Gary Guo) * Store the rgb colors on the st7735 layer (Douglas Reis) * Fix the orientation enum (Douglas Reis) * Fix warnings on restrictive compiler flags (Douglas Reis) Signed-off-by: Gary Guo <[email protected]>
Contributor
|
I've fixed this issue by hard-coding the offset in the display driver for now. It is not on the roadmap to add the read part of the SPI host, so updating to the latest display driver would not help. |
marnovandermaas
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of lowRISC/sonata-system#55