Skip to content

Environment Setup and Makefile Target Errors #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WajahatRiaz wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Environment Setup and Makefile Target Errors #2277

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0d6be3
build: Enable C++ exceptions in verilator build
WajahatRiaz May 17, 2025
67f85c6
modify the CSR testbench Makefile to include the Verilator include pa…
WajahatRiaz May 17, 2025
7ad1a9b
Adding changes for targes to run on verilator
WajahatRiaz May 17, 2025
950583d
Fixing march flags as per lowrisc-toolchain
WajahatRiaz May 19, 2025
00833d8
Adding fix for possible paths for verilator include directory and hea…
WajahatRiaz May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dv/cs_registers/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,13 @@ else
$(TOOLDIR)share/verilator/include \
$(TOOLDIR)share/verilator/include/vltstd \
/usr/share/verilator/include \
/usr/share/verilator/include/vltstd \
/usr/local/share/verilator/include \
/usr/local/share/verilator/include/vltstd \
/opt/verilator/share/verilator/include \
$(HOME)/verilator/include
/opt/verilator/share/verilator/include/vltstd \
$(HOME)/verilator/include \
$(HOME)/verilator/include/vltstd
Copy link
Contributor

@marnovandermaas marnovandermaas May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I think it's a good idea to list all possible paths where Verilator is installed. What's the problem with requiring people to define verilator root?

Copy link
Author

@WajahatRiaz WajahatRiaz May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defined verilator root and still couldn't find the svdpi header file.

Copy link
Contributor

@marnovandermaas marnovandermaas May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the problem I'm on board with adding the "vlstd" path to the Verilator root, but I don't think it's a good idea to add all the possible locations where Verilator could be installed.


# Find first valid include path
VERILATOR_INCLUDE := $(firstword $(foreach dir,$(VERILATOR_INCLUDE_PATHS),$(if $(wildcard $(dir)/svdpi.h),$(dir),)))
Expand All @@ -48,6 +52,7 @@ else
$(warning Searched in: $(VERILATOR_INCLUDE_PATHS))
$(warning You can manually specify it using: make build-csr-test INCLUDES="-I/path/to/verilator/include -I./env -I./rst_driver -I./reg_driver -I./model")
$(warning Or set VERILATOR_ROOT environment variable pointing to your Verilator installation)
VERILATOR_INCLUDE = # Leave empty or set a default fallback path if applicable
endif
endif

Expand Down