sim: display ISA configuration string at simulation startup - #2488
Open
devtyagi3909 wants to merge 1 commit into
Open
sim: display ISA configuration string at simulation startup#2488devtyagi3909 wants to merge 1 commit into
devtyagi3909 wants to merge 1 commit into
Conversation
GetIsaString() was implemented in SimpleSystem but never called or displayed, so users had no way to confirm which ISA parameters their Verilator simulation was built with. Print the ISA string in the startup banner alongside the existing 'Simulation of Ibex' header. This produces output of the form: Simulation of Ibex ================== ISA: rv32imc which makes it straightforward to verify the active configuration without having to cross-reference build flags. Fixes lowRISC#1364
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1364.
GetIsaString()was already implemented inSimpleSystemto return the Spike-compatible ISA string derived from the elaborated Verilator parameters (e.g.rv32imc,rv32imcb). However it was never called or displayed, so users had no way to confirm which ISA parameters their simulation was actually built with without cross-referencing build flags.This adds a single line to the startup banner in
SimpleSystem::Run():No new logic introduced — this strictly wires the existing function into the existing output path.