[bazel] Migrate all source repositories (non-Bazel aware) to bzlmod #25714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
force-pushed
the
bzlmod-misc-repos
branch
3 times, most recently
from
b3481bd to
a5c4ee5
Compare
jwnrt
force-pushed
the
bzlmod-misc-repos
branch
from
a5c4ee5 to
37da460
Compare
jwnrt
force-pushed
the
bzlmod-misc-repos
branch
from
37da460 to
58367c5
Compare
pamaury
reviewed
Jan 3, 2025
pamaury
reviewed
Jan 3, 2025
jwnrt
force-pushed
the
bzlmod-misc-repos
branch
from
58367c5 to
babc171
Compare
The verible syntax python file here is used directly within our Bazel repository, not through its own repository. Removed. The `lowrisc_misc_linters` repository should have been removed when it was migrated to Bzlmod. Signed-off-by: James Wainwright <[email protected]>
This was a transitive dependency of Buildifier that should have been removed when that was migrated to Bzlmod. Signed-off-by: James Wainwright <[email protected]>
These paths are not stable and should not be hard coded. Files must use the path relative to `includes = [...]` parameters added to `cc_library` rules. These paths change under bzlmod. Signed-off-by: James Wainwright <[email protected]>
These repositories are not Bazel-aware, we're only using them for their sources. Each dependency's `_repos()` function is made private and run from a bzlmod extension which is called from `MODULE.bazel` and the repositories are brought into the module's namespace. Signed-off-by: James Wainwright <[email protected]>
This matches the convention of other third party packages with patches. Signed-off-by: James Wainwright <[email protected]>
This is no longer used / usable with Bzlmod. Use `override_repo` in the `MODULE.bazel` instead. Signed-off-by: James Wainwright <[email protected]>
This functionality is now implemented directly in bzlmod using the `override_repo` and `inject_repo` functions in `MODULE.bazel`. Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
bzlmod-misc-repos
branch
from
babc171 to
1b61e88
Compare
pamaury
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORKSPACE.bzlmod.#include "external/..."paths to included directories in linker scripts._repos()functions private, run them from extensions, and extract repos.patchessubdirectories to match existingthird_partyconvention.http_archive_or_localrule.override_repoandinject_repo.